Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrwl and nx dependencies are incompatible after update #19314

Closed
1 of 4 tasks
robertIsaac opened this issue Sep 24, 2023 · 3 comments
Closed
1 of 4 tasks

nrwl and nx dependencies are incompatible after update #19314

robertIsaac opened this issue Sep 24, 2023 · 3 comments

Comments

@robertIsaac
Copy link
Contributor

Current Behavior

nx migrate latest doesn't update @nrwl/* dependencies

Expected Behavior

nx migrate should update @nrwl/* dependencies as well
or we remove the dependencies between @nx and @nrwl

GitHub Repo

https://github.com/robertIsaac/nx-ng-nest

Steps to Reproduce

  1. generate a repo with nx 16.8.1
  2. run nx migrate latest to update to 16.9.0 (latest commit in the provided repo)

Nx Report

Node   : 18.16.0
   OS     : win32-x64
   npm    : 9.6.7

   nx                      : 16.9.0
   @nx/js                  : 16.9.0
   @nrwl/js                : 16.8.1
   @nx/jest                : 16.9.0
   @nrwl/jest              : 16.8.1
   @nx/linter              : 16.9.0
   @nrwl/linter            : 16.8.1
   @nx/workspace           : 16.9.0
   @nx/angular             : 16.9.0
   @nrwl/angular           : 16.8.1
   @nx/cypress             : 16.9.0
   @nx/devkit              : 16.9.0
   @nx/eslint-plugin       : 16.9.0
   @nrwl/eslint-plugin-nx  : 16.8.1
   @nx/nest                : 16.9.0
   @nrwl/nest              : 16.8.1
   @nx/node                : 16.9.0
   @nrwl/tao               : 16.9.0
   @nx/webpack             : 16.9.0
   nx-cloud                : 16.4.0
   typescript              : 5.1.6
   ---------------------------------------
   Community plugins:
   @nguniversal/builders       : 16.2.0
   @nguniversal/express-engine : 16.2.0
   ---------------------------------------
   The following packages should match the installed version of nx
     - @nrwl/js@16.8.1
     - @nrwl/jest@16.8.1
     - @nrwl/linter@16.8.1
     - @nrwl/angular@16.8.1
     - @nrwl/eslint-plugin-nx@16.8.1
     - @nrwl/nest@16.8.1

   To fix this, run `nx migrate nx@16.9.0`

Failure Logs

The following packages should match the installed version of nx
     - @nrwl/js@16.8.1
     - @nrwl/jest@16.8.1
     - @nrwl/linter@16.8.1
     - @nrwl/angular@16.8.1
     - @nrwl/eslint-plugin-nx@16.8.1
     - @nrwl/nest@16.8.1

   To fix this, run `nx migrate nx@16.9.0`

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

running nx migrate nx@16.9.0 just add one empty line at the end of the package.json file

@AgentEnder
Copy link
Member

Going to close this in favor of #19318, while this one is newer I seen the other and replied there first. Thanks. 🙏

@robertIsaac
Copy link
Contributor Author

Going to close this in favor of #19318, while this one is newer I seen the other and replied there first. Thanks. 🙏

What is important it's fixed
Thanks

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants