Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nx/angular depends on @nrwl/angular #19318

Closed
1 of 4 tasks
woppa684 opened this issue Sep 25, 2023 · 2 comments · Fixed by #19334
Closed
1 of 4 tasks

@nx/angular depends on @nrwl/angular #19318

woppa684 opened this issue Sep 25, 2023 · 2 comments · Fixed by #19334
Assignees
Labels

Comments

@woppa684
Copy link

woppa684 commented Sep 25, 2023

Current Behavior

I get peer dependency mismatches like these:

 WARN  Issues with peer dependencies found
.
└─┬ @nx/angular 16.9.0
  └─┬ @nrwl/angular 16.6.0
    └─┬ @nx/angular 16.6.0
      ├── ✕ unmet peer esbuild@^0.17.5: found 0.19.3
      └─┬ @nrwl/angular 16.6.0
        └─┬ @nx/angular 16.6.0
          └── ✕ unmet peer esbuild@^0.17.5: found 0.19.3

Also, the other way round, @nrwl/angular depends on @nx/angular so that is also not very convenient.

Expected Behavior

No issues with peer dependencies

GitHub Repo

No response

Steps to Reproduce

  1. Upgrading to 16.9.0

Nx Report

>  NX   Report complete - copy this into the issue template

   Node   : 18.16.0
   OS     : win32-x64
   pnpm   : 8.4.0

   nx                      : 16.9.0
   @nx/js                  : 16.9.0
   @nrwl/js                : 16.6.0
   @nx/jest                : 16.9.0
   @nrwl/jest              : 16.6.0
   @nx/linter              : 16.9.0
   @nrwl/linter            : 16.6.0
   @nx/workspace           : 16.9.0
   @nrwl/workspace         : 16.6.0
   @nx/angular             : 16.9.0
   @nrwl/angular           : 16.6.0
   @nx/cypress             : 16.9.0
   @nrwl/cypress           : 16.6.0
   @nx/devkit              : 16.9.0
   @nrwl/devkit            : 16.6.0
   @nx/eslint-plugin       : 16.9.0
   @nrwl/eslint-plugin-nx  : 16.6.0
   @nx/plugin              : 16.9.0
   @nrwl/nx-plugin         : 16.6.0
   @nrwl/tao               : 16.6.0
   @nx/webpack             : 16.9.0
   @nrwl/webpack           : 16.6.0
   typescript              : 5.1.6
   ---------------------------------------
   Local workspace plugins:
         @canonpp/coes-sdk
   ---------------------------------------
   The following packages should match the installed version of nx
     - @nrwl/js@16.6.0
     - @nrwl/jest@16.6.0
     - @nrwl/linter@16.6.0
     - @nrwl/workspace@16.6.0
     - @nrwl/angular@16.6.0
     - @nrwl/cypress@16.6.0
     - @nrwl/devkit@16.6.0
     - @nrwl/eslint-plugin-nx@16.6.0
     - @nrwl/nx-plugin@16.6.0
     - @nrwl/tao@16.6.0
     - @nrwl/webpack@16.6.0

   To fix this, run `nx migrate nx@16.9.0`

Failure Logs

Nothing, apart from the peer dependency issue and the above output (by the way, running nx migrate does not do anything). Possibly related to #19314?

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

The dependencies of @nx/angular list @nrwl/angular, that does not seem right, does it?

https://www.npmjs.com/package/@nx/angular?activeTab=dependencies

"dependencies": {
    "@phenomnomnominal/tsquery": "~5.0.1",
    "@typescript-eslint/type-utils": "^5.36.1",
    "chalk": "^4.1.0",
    "find-cache-dir": "^3.3.2",
    "ignore": "^5.0.4",
    "magic-string": "~0.30.2",
    "minimatch": "3.0.5",
    "semver": "7.5.3",
    "tslib": "^2.3.0",
    "webpack": "^5.80.0",
    "webpack-merge": "^5.8.0",
    "enquirer": "^2.3.6",
    "@nx/devkit": "16.9.0",
    "@nx/cypress": "16.9.0",
    "@nx/jest": "16.9.0",
    "@nx/js": "16.9.0",
    "@nx/linter": "16.9.0",
    "@nx/webpack": "16.9.0",
    "@nx/workspace": "16.9.0",
    "@nrwl/angular": "*"
  },
@AgentEnder AgentEnder added the scope: core core nx functionality label Sep 26, 2023
@AgentEnder
Copy link
Member

Hey @woppa684 - thanks for reporting this. The dependency should be there, its a little silly but shouldn't have any effects. Unfortunately, some recent changes broke how that is specified, as it should be resolved to the same version as all of the other Nx deps. @JamesHenry and I are looking into it.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants