Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): skip formatting files in nested generator calls #15961

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 29, 2023

Current Behavior

  • Generators invoking other generators don't pass skipFormat: true to the nested generators which results in multiple formatFiles invocations during a generator run.
  • Some generators invoked as part of other generator runs don't support the skipFormat flag.

The above have performance implications in the generator runs.

Expected Behavior

Generators invoking other generators explicitly pass the skipFormat: true to prevent multiple formatFiles runs during a generator run.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 29, 2023
@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 2:50PM (UTC)

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nx-plugin changes look good

@FrozenPandaz FrozenPandaz merged commit 4eb7cc7 into nrwl:master Mar 31, 2023
@leosvelperez leosvelperez deleted the misc/skip-nested-format-files branch March 31, 2023 15:32
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants