fix(nextjs): Custom server should run on fresh apps without errors #17806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6ec4b62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jaysoo
approved these changes
Jun 26, 2023
jaysoo
reviewed
Jun 26, 2023
ndcunningham
force-pushed
the
fix/nextjs-run-custom-server-fresh-app
branch
from
d4b3cec
to
86e642f
Compare
ndcunningham
force-pushed
the
fix/nextjs-run-custom-server-fresh-app
branch
from
86e642f
to
79073e4
Compare
mandarini
approved these changes
Jun 27, 2023
ndcunningham
force-pushed
the
fix/nextjs-run-custom-server-fresh-app
branch
from
79073e4
to
282c85a
Compare
ndcunningham
force-pushed
the
fix/nextjs-run-custom-server-fresh-app
branch
from
282c85a
to
6ec4b62
Compare
|
This fixes #17270 . Thank you! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when we ran custom server it would result in a error for fresh NextJs Apps
This was because the server code was generated
./server/main.tswhile the@nx/js:nodeexecutor expects it from the root of the project.This change should address this issue.