Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nx-plugin): pass full context into parseTargetString #19154

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

When calling parseTargetString we pass a project graph, which means that the full target string is required

Expected Behavior

When calling parseTargetString we pass an executor context, which allows using build to reference {projectName}:build

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner September 13, 2023 20:19
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2023 8:20pm

@FrozenPandaz FrozenPandaz merged commit 82fb209 into nrwl:master Sep 21, 2023
3 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants