-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): Support loading remotes via library: var #19192
feat(react): Support loading remotes via library: var #19192
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f220342. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
eca8fe3
to
5739faf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment, but overall looks good!!
Can we also make sure this is added to Angular?
it('should navigate to /about from /', () => { | ||
cy.get('a').contains('${remote}').click(); | ||
cy.url().should('include', '/${remote}'); | ||
getGreeting().contains('Welcome ${remote}'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be an error with this function, do you need to import it?
c03fa73
to
d07a40d
Compare
794e193
to
72fa61f
Compare
We could add a task for angular all that would be needed is to update the |
e06d3ef
to
7771472
Compare
7771472
to
f220342
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR updates
withModuleFederation
plugin for React apps to now supportlibrary: { type: 'var' }
when loading remotes.With this change, users can now decorate their hosts and remotes with
library: { type: 'var'}
, enabling the remote to be loaded via script.To enable this type of loading you would need to update your host and remote similar to this: