Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): set SWC_NODE_PROJECT before registering @swc-node/register #19239

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Sep 19, 2023

Current Behavior

swc does not use the tsconfig.base.json file in integrated repos for use in in-process transpilation

Expected Behavior

Set SWC_NODE_PROJECT to tsconfig.base.json if it exists. (Otherwise swc will just use tsconfig.json anyway)

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested a review from a team as a code owner September 19, 2023 17:40
@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 5:58pm

@Cammisuli Cammisuli changed the title fix(core): set SWC_NODE_PROJECT for swc registering fix(core): set SWC_NODE_PROJECT before registering @swc-node/register Sep 19, 2023
@FrozenPandaz FrozenPandaz merged commit 9a919a0 into nrwl:master Sep 20, 2023
3 checks passed
@Cammisuli Cammisuli deleted the set_swc_node_project branch September 20, 2023 13:31
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants