fix(nextjs): do not warn on NX_INVOKED_BY_RUNNER and only show warning once #19254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a deprecation warning for environment variables prefixed with
NX_
(that are not set by Nx or Nx Cloud). Since Next.js apps run both in server and browser, any environment variables should only be used by the server (in RSC or API route), to prevent security leaks.However, our warnings did not exclude
NX_INVOKED_BY_RUNNER
, which is set by the Nx Cloud runner. This is causing user confusion. We are also warning too many times, since Next.js build/serve can load webpack config up to three times (browser, server, edge).This PR makes the warning go away unless user explicitly sets a custom
NX_
variable, thinking that it will be available for use in the browser. When the warning does show up, it will only show once.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #