fix(core): do not attempt to publish private npm packages #19299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
requested review from
a team,
FrozenPandaz,
vsavkin,
AgentEnder and
jaysoo
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8a6421c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
fahslaj
approved these changes
Sep 22, 2023
FrozenPandaz
requested changes
Sep 22, 2023
| }, | ||
| }); | ||
|
|
||
| describe('nx release - private JS packages', () => { |
There was a problem hiding this comment.
Is it possible to keep this in 1 file so that we don't have to create a new workspace for this test?
FrozenPandaz
approved these changes
Sep 22, 2023
jaysoo
approved these changes
Sep 22, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We attempt to publish all packages in our npm implementation of a release-publish executor.
Expected Behavior
We attempt to publish all public packages in our npm implementation of a release-publish executor, but skip any marked as private.
Related Issue(s)
Fixes #