-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): add @babel/plugin-transform-class-properties to babel preset #19818
fix(js): add @babel/plugin-transform-class-properties to babel preset #19818
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 116e56b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
784ba3c
to
3587780
Compare
3587780
to
eeb301f
Compare
any approvers in the building so we can have it in the next version? 😉 |
@AgentEnder @JamesHenry wdyt? |
Can confirm this fixes an issue we hit in the upgrade as well |
It's supposed to be added in |
f373f44
to
116e56b
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
After removing the deprecated babel proposal plugin, apps that use classes have issues with field initialization inside constructors. (it broke a few of our apps)
Expected Behavior
Current applications should not break, and constructor field initialization should preserve TS rules.
Related Issue(s)
Fixes #19817