Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): canonicalize watch event paths on all linux distros #19848

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

Cammisuli
Copy link
Member

Current Behavior

Sometimes watch events on linux contain symlinked paths to node_modules, which become ignored due to gitignore rules.

Expected Behavior

Canonicalizing watch events on all linux distros would give the real file path, which will not be ignored

Related Issue(s)

Fixes #19312

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 25, 2023 9:58pm

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) October 25, 2023 21:53
@FrozenPandaz FrozenPandaz merged commit a7e0abd into nrwl:master Oct 25, 2023
6 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native file watcher ignores packages in an npm workspace
2 participants