Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Update types version so that there is no mismatch when using yarn #19882

Merged

Conversation

ndcunningham
Copy link
Contributor

When using yarn to create a react app with style-components selected it resolves mismatching of types

├─┬ @testing-library/react@14.0.0
│ └─┬ @types/react-dom@18.2.14
│   └── @types/react@18.2.33
├─┬ @types/react-dom@18.2.9
│ └── @types/react@18.2.33
├─┬ @types/react-is@18.2.2
│ └── @types/react@18.2.33
├── @types/react@18.2.24
└─┬ @types/styled-components@5.1.26
  ├─┬ @types/hoist-non-react-statics@3.3.4
  │ └── @types/react@18.2.33
  └── @types/react@18.2.33

Which would make running nx build result in a error.

Updating the types to the latest patch version should resolve this mismatch issue.

@ndcunningham ndcunningham added the scope: react Issues related to React support for Nx label Oct 26, 2023
@ndcunningham ndcunningham self-assigned this Oct 26, 2023
@ndcunningham ndcunningham requested a review from a team as a code owner October 26, 2023 16:50
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 4:59pm

@nx-cloud
Copy link

nx-cloud bot commented Oct 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7158dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run @nx/nx-source:local-registry --location none --clear true --storage /var/folders/g1/43z0w1wj4p5dlcfxvdr9zhx80000gn/T/local-registry/storage/e2e-detox
nx run @nx/nx-source:local-registry --location none --clear true --storage /var/folders/g1/43z0w1wj4p5dlcfxvdr9zhx80000gn/T/local-registry/storage/e2e-expo
✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@ndcunningham ndcunningham merged commit f9fc3dd into nrwl:master Oct 26, 2023
6 checks passed
@ndcunningham ndcunningham deleted the fix/update-react-type-versions branch October 26, 2023 19:45
Copy link

github-actions bot commented Nov 1, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: react Issues related to React support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants