Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): allow numbers following a dash in application prefix #19926

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

leosvelperez
Copy link
Member

For reference: angular/angular-cli@c5827d4#diff-21e22640a309b86842754f526a37c110b6fefd87a11f0bec50f5921035489783

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Oct 30, 2023
@leosvelperez leosvelperez requested a review from a team as a code owner October 30, 2023 09:27
@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 9:28am

@Coly010
Copy link
Contributor

Coly010 commented Oct 30, 2023

I think there is an e2e test that checks failure of my-1-app in CNW that you may need to look at

@leosvelperez leosvelperez merged commit 91c83cb into nrwl:master Oct 30, 2023
6 checks passed
@leosvelperez leosvelperez deleted the angular/cmp-selector-numbers branch October 30, 2023 10:25
FrozenPandaz pushed a commit that referenced this pull request Nov 2, 2023
Copy link

github-actions bot commented Nov 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants