Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): properly sort all workspace files #20013

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Nov 2, 2023

Current Behavior

doing sort on objects, does not sort properly by file

Expected Behavior

Provided sort closure actually uses the file to sort

Related Issue(s)

Fixes #20012

@Cammisuli Cammisuli requested a review from a team as a code owner November 2, 2023 19:26
Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 7:27pm

@Cammisuli Cammisuli enabled auto-merge (squash) November 3, 2023 00:31
@Cammisuli Cammisuli merged commit 9c0e6a1 into nrwl:master Nov 3, 2023
6 checks passed
@Cammisuli Cammisuli deleted the properly-sort-files branch November 3, 2023 01:13
FrozenPandaz pushed a commit that referenced this pull request Nov 3, 2023
Copy link

github-actions bot commented Nov 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX computed hash used for cache is different on every run when no changes are introduced - v2
2 participants