feat(core): change the signature of createNodes to return a project root map instead of project name map #20102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 93ff15d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/create-nodes-root-map
branch
from
f6eff33 to
ff76c60
Compare
AgentEnder
force-pushed
the
feat/create-nodes-root-map
branch
from
ff76c60 to
cc5909e
Compare
FrozenPandaz
approved these changes
Nov 8, 2023
leosvelperez
approved these changes
Nov 8, 2023
AgentEnder
force-pushed
the
feat/create-nodes-root-map
branch
from
cc5909e to
0ad0562
Compare
…oot map instead of project name map
AgentEnder
force-pushed
the
feat/create-nodes-root-map
branch
from
0ad0562 to
93ff15d
Compare
AgentEnder
force-pushed
the
feat/create-nodes-root-map
branch
from
31da2d8 to
93ff15d
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
CreateNodes returns an object containing a map of project name -> project, this is a bit awkward to use when you know that there is another thing providing that info later on. It feels bad to register a target and have to come up with a placeholder name that you know will be overridden.
Expected Behavior
The project root is required anyways, to merge infos together, so use it as the key to the map
Related Issue(s)
Fixes #