Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(misc): re-enable convert-to-monorepo test to test without Nx plugins for now #21544

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 2, 2024

The webpack config doesn't need to be updated for the most part, except for maybe output.path. All paths are relative and should continue to be.

e.g.

const { NxWebpackPlugin } = require('@nx/webpack');
const { join } = require('path');

module.exports = {
  output: {
    path: join(__dirname,  './dist/demo'),
  },
  devServer: {
    port: 4200
  },
  plugins: [
    new NxWebpackPlugin({
      tsConfig: './tsconfig.app.json',
      main: './src/main.ts',
      index: './src/index.html',
      assets: ['./src/favicon.ico']
    })
  ],
};

We'll circle back to this with a proper design after Nx 18 release.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner February 2, 2024 17:41
@jaysoo jaysoo requested a review from Cammisuli February 2, 2024 17:41
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 6:30pm

@FrozenPandaz FrozenPandaz merged commit ce82723 into nrwl:master Feb 2, 2024
6 checks passed
@jaysoo jaysoo deleted the fix_nx_misc branch February 2, 2024 20:59
Copy link

github-actions bot commented Feb 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants