-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix): add vite mode support #22757
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4bb66e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Hey @unrealsolver Thanks for the contribution, however, there's a lot more we need to consider to actual support While this does allow executors to use vite for remix, there are other things that need to be considered.
I really do appreciate you attempting to help out to get this over the line, but the scale of the work involved is large. |
@Coly010 , thanks for the check-list, I'll add it to the PR to track progress. This PR is still WIP, I just did the most critical work so I can use Nx with manually migrated project locally. I'll put other pieces of work during the next week or so. |
03e7ad5
to
4bb66e2
Compare
@Coly010 is there any timeline on getting this done. Having to rely on some custom patches to keep my build process working. There is also the fact now remix and react router are merging which may require more work https://remix.run/blog/merging-remix-and-react-router. Thanks. |
No timeline yet unfortunately and yes, currently aware of the react-router merger. In contact with Ryan Florence about it 👍 |
I'm not quite sure if you're about to use code from this pr, but if so please consider public being build inside |
I'm going to close this PR as it has not been updated in a few months now. We have Vite support added to our internal roadmap and will be addressing it soon |
Good to hear, is there some way to follow that progress? |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Remix plugin is using older 'classic' remix tooling.
Expected Behavior
Remix plugin is using up to date tooling and configurations
Related Issue(s)
#22551
Fixes #
#22035
Checklist:
--bundler
option to support classic or vite during generationOther fixes changes:
Preview
You can replace @nx/remix with this repo.
Add this dependency entry into your package.json:
https://github.com/unrealsolver/nx-remix-vite/tree/main