Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(misc): migrate rollup to picocolors #28186

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Sep 28, 2024

Migrates from chalk to picocolors.

there wasnt a scope for rollup so I used core here

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 1, 2024 10:42am

Migrates from `chalk` to `picocolors`.
@43081j
Copy link
Contributor Author

43081j commented Sep 28, 2024

I'm a little stuck with the failures

a re-run produced a different failure, but usually along the lines of an import not existing

locally, this builds just fine and I cant see anything obvious in the diff that'd cause this

@JamesHenry JamesHenry changed the title cleanup(core): migrate rollup to picocolors cleanup(misc): migrate rollup to picocolors Oct 1, 2024
@JamesHenry JamesHenry merged commit 2f09285 into nrwl:master Oct 1, 2024
6 checks passed
@JamesHenry
Copy link
Collaborator

@43081j Sorry not sure, I just synced up and everything passed, thanks again!

@43081j 43081j deleted the whiteboards-round-7 branch October 1, 2024 17:40
Copy link

github-actions bot commented Oct 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants