feat(core): nx-plugin-checks accounts for outDir and rootDir of projects when checking file existence #29391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your CI Pipeline Execution ↗ for commit 0e6cbfb is in progress ⏳
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
fix/nx_plugin_checks
branch
2 times, most recently
from
e9bf0ca to
1605bc9
Compare
…cts when checking file existence
jaysoo
force-pushed
the
fix/nx_plugin_checks
branch
from
1605bc9 to
0e6cbfb
Compare
leosvelperez
approved these changes
Dec 18, 2024
ndcunningham
pushed a commit
that referenced
this pull request
Dec 20, 2024
…cts when checking file existence (#29391) For Nx plugins that use the the new TS solution setup, we need to account for `generators.json`, `executors.json`, and `migrations.json` pointing to `dist` rather than source. This PR adds two options, `rootDir` and `outDir`, that allows the lint rule to check the source files rather than depend on build artifacts. The defaults are what we generate our plugins with. <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Nx plugins that use the the new TS solution setup, we need to account for
generators.json,executors.json, andmigrations.jsonpointing todistrather than source.This PR adds two options,
rootDirandoutDir, that allows the lint rule to check the source files rather than depend on build artifacts. The defaults are what we generate our plugins with.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #