Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): fix typo so exports field in package.json is properly sorted #29643

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix(js): fix typo so exports field in package.json is properly sorted #29643

merged 2 commits into from
Jan 16, 2025

Conversation

leosvelperez
Copy link
Member

Current Behavior

It tries to sort exported which is an invalid field.

Expected Behavior

It should sort exports.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jan 16, 2025
@leosvelperez leosvelperez requested review from a team as code owners January 16, 2025 09:42
@leosvelperez leosvelperez requested a review from Coly010 January 16, 2025 09:42
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 0:36am

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 16, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f3440a2.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 28m 14s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=d0078... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation --no-dte ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-16 13:08:12 UTC

@jaysoo jaysoo merged commit ed6b220 into master Jan 16, 2025
6 checks passed
@jaysoo jaysoo deleted the js/fix-sort-package-json-fields-typo branch January 16, 2025 13:44
FrozenPandaz pushed a commit that referenced this pull request Jan 17, 2025
@leosvelperez @FrozenPandaz
fix(js): fix typo so exports field in package.json is properly sort…
117f756 
…ed (#29643)

## Current Behavior

It tries to sort `exported` which is an invalid field.

## Expected Behavior

It should sort `exports`.

## Related Issue(s)

Fixes #

(cherry picked from commit ed6b220)
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

@Coly010 Coly010 Coly010 approved these changes

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@mandarini mandarini Awaiting requested review from mandarini mandarini is a code owner

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner automatically assigned from nrwl/nx-testing-tools-reviewers

Assignees

@leosvelperez leosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leosvelperez @jaysoo @Coly010