fix(nuxt): correct webServerAddress and webServerCommand options in add-e2e.ts generator. #29713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit c60430a.
☁️ Nx Cloud last updated this comment at |
makp0
force-pushed
the
fix/nuxt-generator-e2e
branch
2 times, most recently
from
bb239ac to
95fc634
Compare
…dd-e2e.ts generator
makp0
force-pushed
the
fix/nuxt-generator-e2e
branch
from
95fc634 to
c60430a
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, the add-e2e.ts generator has redundant lines for the webServerAddress and webServerCommand configuration when generating Playwright configuration.
Produces
TypeError: Invalid URLwhen running playwright tests on a clean create-nx-workspace project.Expected Behavior
The generator should configure webServerAddress and webServerCommand correctly. The changes fix the configuration generation for Playwright tests.