WIP: Continuous Tasks #29750
Draft
WIP: Continuous Tasks #29750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 1d9c69a.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
66b73fc to
3ce0b72
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
3ce0b72 to
9704043
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
9704043 to
6273072
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
6273072 to
b33ed45
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
b33ed45 to
cc9549c
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-29750-cc9549c my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29750-cc9549c
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
cc9549c to
91e243b
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
8bed8d6 to
a0967d3
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
2 times, most recently
from
fd005c5 to
89b7c21
Compare
FrozenPandaz
force-pushed
the
continuous-tasks
branch
from
bd960c0 to
80f6267
Compare
FrozenPandaz
commented
Jan 31, 2025
| !shouldPrefix | ||
| ) { | ||
| // todo implement this | ||
| // return await this.runTaskInForkedProcess( |
There was a problem hiding this comment.
Removing this
| // Disable the pseudo terminal if this is a run-many | ||
| const disablePseudoTerminal = !this.initiatingProject; | ||
| // Disable the pseudo terminal if this is a run-many or when running a continuous task | ||
| const disablePseudoTerminal = !this.initiatingProject || task.continuous; |
There was a problem hiding this comment.
This seems wrong 🤔 a task can be continuous be the only thing running.
| @@ -725,4 +767,87 @@ export class TaskOrchestrator { | |||
| } | |||
|
|
|||
| // endregion utils | |||
| private async startInfiniteTask( | |||
There was a problem hiding this comment.
Change this to continuous
Comment on lines
+517
to
+521
| Object.keys(taskGraph.continuousDependencies).forEach((taskId) => { | ||
| taskGraph.continuousDependencies[taskId].forEach((d) => { | ||
| reverseTaskDeps[d].push(taskId); | ||
| }); | ||
| }); |
| @@ -135,18 +135,37 @@ export class PseudoTerminal { | |||
| } | |||
| } | |||
|
|
|||
| let i = 0; | |||
| @@ -30,19 +31,37 @@ describe('PseudoTerminal', () => { | |||
| }, 1000); | |||
|
|
|||
| it('should subscribe to output', (done) => { | |||
| const childProcess = terminal.runCommand('echo "hello world"'); | |||
| const childProcess = terminal.runCommand('sleep 1 && echo "hello world"'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP
An RFC about this feature is happening here: #29025
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #