Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): identify correct circular dependecies #29759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

currently, when detecting circular dep in release, it tests dependentProject.target === projectName, which adds all projects as circular deps. because filter allDependentProjects is localPackageDependency.target === projectName, so dependentProject.target === projectName is always true

Expected Behavior

correct the logic of detecting circular deps, it should test

  • current project.target -> a (source: current project, target: a)
  • a.target -> current project (source: a, target: current project)

Related Issue(s)

Fixes #28336

@xiongemi xiongemi requested a review from a team as a code owner January 27, 2025 05:48
@xiongemi xiongemi requested a review from ndcunningham January 27, 2025 05:48
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Jan 27, 2025 5:48am

Copy link

nx-cloud bot commented Jan 27, 2025

View your CI Pipeline Execution ↗ for commit 19136bf.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 40m 25s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 59s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=a8aba... ✅ Succeeded 27s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 25s View ↗
nx documentation --no-dte ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-27 06:27:13 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX release doesn't propagate new version to dependent projects
1 participant