Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Optimize loading local plugin TS options #29774

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ethantkoenig
Copy link
Contributor

Current Behavior

All of the TS source trees are unnecessarily traversed when a local plugin is being registered.

Expected Behavior

TS source trees are not unnecessarily traversed.

Related Issue(s)

Fixes #29102 (see issue for more context)

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 5:56am

Copy link

nx-cloud bot commented Jan 28, 2025

View your CI Pipeline Execution ↗ for commit ae78d8f.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 36m 31s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 1s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=e0c49... ✅ Succeeded 27s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 26s View ↗
nx documentation --no-dte ✅ Succeeded 1m 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 06:37:48 UTC

@ethantkoenig ethantkoenig marked this pull request as ready for review January 28, 2025 16:24
@ethantkoenig ethantkoenig requested a review from a team as a code owner January 28, 2025 16:24
@ethantkoenig ethantkoenig requested a review from xiongemi January 28, 2025 16:24
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@leosvelperez leosvelperez merged commit 9b70596 into nrwl:master Jan 29, 2025
5 checks passed
Copy link

github-actions bot commented Feb 4, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization: don't read full TS config in registerPluginTSTranspiler
2 participants