Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rspack): handle configs with default exports #29825

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 31, 2025

Current Behavior

When we resolve the config file for rspack, it can be provided in a few different formats:

config

config.default

config.default.default

We do not handle if the config is provided in any of the named default methods.

Expected Behavior

Handle named defaults for the resolved user config for Rspack.

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 1:36pm

@Coly010 Coly010 requested a review from a team as a code owner January 31, 2025 13:33
@Coly010 Coly010 self-assigned this Jan 31, 2025
Copy link

nx-cloud bot commented Jan 31, 2025

View your CI Pipeline Execution ↗ for commit b50aa52.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 21m 21s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 52s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=7d864... ✅ Succeeded 19s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 18s View ↗
nx documentation --no-dte ✅ Succeeded 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 14:01:46 UTC

@AgentEnder AgentEnder merged commit 00b9525 into master Jan 31, 2025
11 checks passed
@AgentEnder AgentEnder deleted the rspack/fix-default-config-handling branch January 31, 2025 14:47
Copy link

github-actions bot commented Feb 6, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants