fix(nx-plugin): reduce memory usage of projectReportAll when using @nx/gradle plugin
#29829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
4 tasks
|
View your CI Pipeline Execution ↗ for commit 843e113.
☁️ Nx Cloud last updated this comment at |
The project-report Gradle plugin includes 4 tasks [dependencyReport, propertyReport, taskReport, htmlDependencyReport ] but only uses the dependency, propertyReport and taskReport tasks. The htmlDependencyReport is intended for viewing in a browser and is often too large for Nodes default memory settings causing the Nx graph creation to fail. This change disables the task completely for Nxs purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project-report Gradle plugin includes 4 tasks [dependencyReport, propertyReport, taskReport, htmlDependencyReport ] but only uses the dependency, propertyReport and taskReport tasks. The htmlDependencyReport is intended for viewing in a browser and is often too large for Nodes default memory settings causing the Nx graph creation to fail. This change disables the task completely for Nxs purposes.
Current Behavior
The
@nx/gradleplugin template includes theproject-reportGradle plugin, including thehtmlDependencyReporttask, which it does not require to compute the Graph but which consumes lots of memory in process, resulting in OutOfMemory errors when computing the Graph.Expected Behavior
Projects to which the
@nx/gradleplugin is added will continue to include theproject-reportgradle plugin but disable thehtmlDependencyReporttask to reduce the risk of this issue.Related Issue(s)
#27750
Fixes #27750