Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misc): generate config with output contained within project root #29850

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(misc): generate config with output contained within project root #29850

merged 2 commits into from
Feb 4, 2025

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 3, 2025 •
edited
Loading

Updates some generators to ensure the build tool produces the output contained within the project root for the TS solution setup.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 3, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 3:51pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e444549.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 42s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 8s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 3m 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-03 16:26:55 UTC

@leosvelperez leosvelperez marked this pull request as ready for review February 3, 2025 16:29
@leosvelperez leosvelperez requested review from a team as code owners February 3, 2025 16:29
@leosvelperez leosvelperez requested a review from jaysoo February 3, 2025 16:29
@jaysoo jaysoo merged commit 8d056c9 into master Feb 4, 2025
12 checks passed
@jaysoo jaysoo deleted the misc/ts-solution-output-fixes branch February 4, 2025 14:16
FrozenPandaz pushed a commit that referenced this pull request Feb 6, 2025
@leosvelperez @FrozenPandaz
fix(misc): generate config with output contained within project root (#…
93773c6 
…29850)

Updates some generators to ensure the build tool produces the output
contained within the project root for the TS solution setup.

## Current Behavior

## Expected Behavior

## Related Issue(s)

Fixes #

(cherry picked from commit 8d056c9)
FrozenPandaz pushed a commit that referenced this pull request Feb 6, 2025
@leosvelperez @FrozenPandaz
fix(misc): generate config with output contained within project root (#…
faeb2a1 
…29850)

Updates some generators to ensure the build tool produces the output
contained within the project root for the TS solution setup.

## Current Behavior

## Expected Behavior

## Related Issue(s)

Fixes #

(cherry picked from commit 8d056c9)
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

Assignees

@leosvelperez leosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leosvelperez @jaysoo