feat(rspack): improve plugin createNodes performance #29876
Merged
+26
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit c10edf7.
☁️ Nx Cloud last updated this comment at |
Coly010
force-pushed
the
rspack/create-nodes-perf
branch
from
89aaa41 to
67ae768
Compare
jaysoo
approved these changes
Feb 4, 2025
Coly010
force-pushed
the
rspack/create-nodes-perf
branch
from
67ae768 to
9eb2067
Compare
Coly010
force-pushed
the
rspack/create-nodes-perf
branch
from
9eb2067 to
c10edf7
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Current Behavior Currently, calculating nodes via the `@nx/rspack/plugin` takes a long time because the hash generation attempts to hash every source file. This is problematic because the targets that are inferred do not rely on the source files themselves and rather just the config file. It also means the time taken to infer the targets grows as the project grows. ## Expected Behavior Calculate the hash based off the config file and the installed dependencies, allowing it to scale as the project grows and allowing it to be invalidated if dependencies change. ## Tested Results Application with 90k files Previous: 2mins New: 1.18s (cherry picked from commit 18c555a)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Current Behavior Currently, calculating nodes via the `@nx/rspack/plugin` takes a long time because the hash generation attempts to hash every source file. This is problematic because the targets that are inferred do not rely on the source files themselves and rather just the config file. It also means the time taken to infer the targets grows as the project grows. ## Expected Behavior Calculate the hash based off the config file and the installed dependencies, allowing it to scale as the project grows and allowing it to be invalidated if dependencies change. ## Tested Results Application with 90k files Previous: 2mins New: 1.18s (cherry picked from commit 18c555a)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, calculating nodes via the
@nx/rspack/plugintakes a long time because the hash generation attempts to hash every source file.This is problematic because the targets that are inferred do not rely on the source files themselves and rather just the config file.
It also means the time taken to infer the targets grows as the project grows.
Expected Behavior
Calculate the hash based off the config file and the installed dependencies, allowing it to scale as the project grows and allowing it to be invalidated if dependencies change.
Tested Results
Application with 90k files
Previous: 2mins
New: 1.18s