fix(core): create multi-glob function #29880
Merged
+343
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 95ff39b.
☁️ Nx Cloud last updated this comment at |
Cammisuli
force-pushed
the
cammisuli/multi-globs
branch
from
0c6c222 to
0a0be97
Compare
|
Have we checked if there is a noticeable perf difference when running ~10 plugins? |
Cammisuli
force-pushed
the
cammisuli/multi-globs
branch
from
eac7070 to
f9eb5a1
Compare
Cammisuli
commented
Feb 6, 2025
Comment on lines
159
to
161
| } else { | ||
| // if there is no glob in the plugin, add an empty glob so that we can still map the globs by index to the plugin | ||
| globPatterns.push(''); |
There was a problem hiding this comment.
before going into here, we should filter out the plugins that do not have createNodes already. Since they are not going to be used for creating the project grap
This ensures consistent indexing between glob patterns and plugins. It prevents potential errors when mapping plugins to their respective globs.
- Add missing semicolon in `retrieve-workspace-files.ts`. - Correct indentation in `retrieve-workspace-files.spec.ts` for readability.
FrozenPandaz
force-pushed
the
cammisuli/multi-globs
branch
from
f9eb5a1 to
6cc2644
Compare
FrozenPandaz
approved these changes
Feb 7, 2025
| @@ -1678,6 +1678,16 @@ describe('project-configuration-utils', () => { | |||
| ], | |||
| }; | |||
|
|
|||
| const noProjectsPlugin: NxPluginV2 = { | |||
|
Thank you @FrozenPandaz @Cammisuli and @AgentEnder 🙌🏻 🙇🏻 |
jaysoo
pushed a commit
that referenced
this pull request
Feb 12, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Whenever there are multiple plugins using in a workspace, all the configuration paths are collected and used as 1 giant glob to test against the workspace context files. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Each plugin configuration glob is now handled separately and are not joined together into one giant one. This allows each glob pattern to have separate files for each plugin. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29473 --------- Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Whenever there are multiple plugins using in a workspace, all the configuration paths are collected and used as 1 giant glob to test against the workspace context files.
Expected Behavior
Each plugin configuration glob is now handled separately and are not joined together into one giant one. This allows each glob pattern to have separate files for each plugin.
Related Issue(s)
Fixes #29473