feat(core): update CNW defaults so they generate a useful workspace by default #29915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit fc3d5f3.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Feb 7, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 8, 2025
…y default (#29915) This PR fixes some inconsistencies when generating a TS solution workspace (e.g. `npx create-nx-workspace --workspace`). If the user chooses `None` stack (or `--preset=ts`), then we continue to default to no Prettier (and ESLint, etc.). However, for React, Vue, and Node, we want the defaults to be useful for users to run lint, test, etc. Thus, they are now updated the default does not opt out of any tooling, but users can still choose no to any of them. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior The defaults for React, Vue, Node are inconsistent (e2e runner is there by default, but not unit test runner, etc.) ## Expected Behavior Defaults are consistent and useful, especially for tutorials. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 6a65db8)
isaacplmann
pushed a commit
that referenced
this pull request
Feb 11, 2025
…y default (#29915) This PR fixes some inconsistencies when generating a TS solution workspace (e.g. `npx create-nx-workspace --workspace`). If the user chooses `None` stack (or `--preset=ts`), then we continue to default to no Prettier (and ESLint, etc.). However, for React, Vue, and Node, we want the defaults to be useful for users to run lint, test, etc. Thus, they are now updated the default does not opt out of any tooling, but users can still choose no to any of them. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior The defaults for React, Vue, Node are inconsistent (e2e runner is there by default, but not unit test runner, etc.) ## Expected Behavior Defaults are consistent and useful, especially for tutorials. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some inconsistencies when generating a TS solution workspace (e.g.
npx create-nx-workspace --workspace).If the user chooses
Nonestack (or--preset=ts), then we continue to default to no Prettier (and ESLint, etc.). However, for React, Vue, and Node, we want the defaults to be useful for users to run lint, test, etc. Thus, they are now updated the default does not opt out of any tooling, but users can still choose no to any of them.Current Behavior
The defaults for React, Vue, Node are inconsistent (e2e runner is there by default, but not unit test runner, etc.)
Expected Behavior
Defaults are consistent and useful, especially for tutorials.
Related Issue(s)
Fixes #