fix(linter): install @eslint/eslintrc package as necessary #29933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 43ccbe7.
☁️ Nx Cloud last updated this comment at |
ndcunningham
approved these changes
Feb 7, 2025
leosvelperez
requested changes
Feb 10, 2025
leosvelperez
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flat compat is necessary, we don't ensure that
@eslint/eslintrcis installed, even though we import it. Depending on the package manager and hoisting, it may still work, but as we see with pnpm v10, it is not working without an explicit dependency inpackage.json.Current Behavior
Some app generators are broken is we use eslint compat.
Expected Behavior
App generators should work.
Related Issue(s)
Fixes #29845