Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add format option for buildable libs #6753

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 17, 2021

This PR adds the --format option to users can specify esm,umd,cjs formats for their library.

For example,

nx build my-lib --format esm,cjs
nx build my-lib --format esm

By default, esm,umd will be used.

Notes

  • Clean up @nrwl/web:package executor
  • Combine react package e2e tests to speed up test time

@vercel
Copy link

vercel bot commented Aug 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/5ABVWT5EhHFTPq7xsotcbtjXz5p2
✅ Preview: https://nx-dev-git-fork-jaysoo-feat-react-lib-format-option-nrwl.vercel.app

@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 8b2ac8e to 871682b Compare August 17, 2021 16:37
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 871682b to d96258f Compare August 17, 2021 17:27
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from d96258f to 98a2add Compare August 17, 2021 17:43
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 98a2add to 9b8b47d Compare August 17, 2021 18:04
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 9b8b47d to 56e7322 Compare August 17, 2021 18:32
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 56e7322 to 90861d0 Compare August 18, 2021 12:59
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 90861d0 to ff20b82 Compare August 18, 2021 13:24
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from ff20b82 to 5bc4f47 Compare August 18, 2021 13:41
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 5bc4f47 to 9a431a7 Compare August 18, 2021 18:42
- Clean up @nrwl/web:package executor
- Combine react package e2e tests to speed up test time
@jaysoo jaysoo force-pushed the feat-react-lib-format-option branch from 9a431a7 to d370835 Compare August 19, 2021 01:59
@jaysoo jaysoo merged commit cddb1ed into nrwl:master Aug 19, 2021
@pstepniewskiconfigit
Copy link

pstepniewskiconfigit commented Sep 2, 2021

@jaysoo @FrozenPandaz there is still reference to umd in package.json after building only esm

ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
- Clean up @nrwl/web:package executor
- Combine react package e2e tests to speed up test time
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants