feat(nextjs): bump Next.js version to 12.0.7

[puku0x]

Current Behavior

Next.js v12.0.0 is used.

Expected Behavior

Next.js v12.0.7 is used.

Related Issue(s)

Closes #7746

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/65Bd7HiEVWSpMjgMvCkzsWkWeXhj
✅ Preview: https://nx-dev-git-fork-puku0x-update-next-1204-nrwl.vercel.app

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit bb9749b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx affected --target=e2e --base=01417d2a9bbc0d4505f00e1b4254a20f20113f3c --head=bb9749bb323fa8b382567dfe5770595e0463bd0f --exclude=e2e-react-native,e2e-detox,e2e-gatsby --parallel --max-parallel=1
	nx run-many --target=build --all --parallel=8
	nx run-many --target=build --all --parallel=8
	nx affected --target=build --base=01417d2a9bbc0d4505f00e1b4254a20f20113f3c --head=bb9749bb323fa8b382567dfe5770595e0463bd0f --parallel --max-parallel=3
	nx affected --target=test --base=01417d2a9bbc0d4505f00e1b4254a20f20113f3c --head=bb9749bb323fa8b382567dfe5770595e0463bd0f --parallel --max-parallel=3
	nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[puku0x]

This is because Nx v13.3.0 supports the latest version of angular-eslint and I expect
it will be shipped soon. 512f094

[puku0x]

Next.js v12.0.5+ supports ESLint v8, which means this migration is suitable for Nx v13.3.0

[MitkoTschimev]

Hi, everybody!

How long will it take to land into the next release?
Sorry for pushing but we really rely on this fix.

[puku0x]

As of v12.0.5, Next.js supports ESLint v8. I will update to the latest version (v12.0.7).
https://github.com/vercel/next.js/releases/tag/v12.0.5

[puku0x]

yarn upgrade eslint-config-next@12.0.7

[puku0x]

yarn upgrade next@12.0.7

[puku0x]

Does Next.js not allow Nx to override process.env.NODE_ENV ?
https://nx.app/runs/M1YuX0TWXjK

@kirjai I need your help to solve the build error.

[puku0x]

@kirjai Does Nrwl team has a plan to upgrate Next.js to 12.0.7? I think it is a great opportunity to upgrade it because Next.js v12.0.5 or later supports ESLint v8 which is the version that Nx v13.3.0 supports too.

[puku0x]

Something wrong in Nx Cloud? I will try it again later.

[kirjai]

@puku0x this is great, thanks a lot for doing the work for this! i'd suggest pushing this branch again in hopes that that was a very temporary Nx Cloud hiccup. i'm not aware of any ongoing issues with it

[AgentEnder]

@puku0x It looks like there is a few other locations with that NODE_ENV change, do you care to apply it in those too? 😞 I don't know why it would have just started.

[puku0x]

@AgentEnder Next.js recently added next/types/global.d.ts to next/index.d.ts in vercel/next.js#28316 , that's why NODE_ENV becomes readonly.

Fortunately, we don’t have to apply the cast to the others because it affects only the package using next.

[puku0x]

Fixed build.impl.ts and server.impl.ts.

[puku0x]

😕

Next.js Applications › should support Less

    Command failed: pnpx nx build app6524812 --withDeps

    DEPRECATION WARNING: --with-deps is deprecated and it will be removed in v14.
    Configure target dependencies instead: https://nx.dev/latest/angular/core-concepts/configuration#target-dependencies.
          
    Cannot read property 'oneOf' of undefined

      436 |     const pm = getPackageManagerCommand();
      437 |     let r = stripConsoleColors(
    > 438 |       execSync(`${pm.runNx} ${command}`, {
          |               ^
      439 |         cwd: opts.cwd || tmpProjPath(),
      440 |         env: { ...(opts.env || process.env), NX_INVOKED_BY_RUNNER: undefined },
      441 |         encoding: 'utf-8',

      at runCLI (../utils/index.ts:438:15)
      at src/next.test.ts:613:29
      at ../../node_modules/tslib/tslib.js:117:75
      at __awaiter (../../node_modules/tslib/tslib.js:113:16)
      at checkApp (src/next.test.ts:416:34)
      at src/next.test.ts:286:11

  ● Next.js Applications › should support Stylus

    Command failed: pnpx nx build app6633046 --withDeps

    DEPRECATION WARNING: --with-deps is deprecated and it will be removed in v14.
    Configure target dependencies instead: https://nx.dev/latest/angular/core-concepts/configuration#target-dependencies.
          
    Cannot read property 'oneOf' of undefined

      436 |     const pm = getPackageManagerCommand();
      437 |     let r = stripConsoleColors(
    > 438 |       execSync(`${pm.runNx} ${command}`, {
          |               ^
      439 |         cwd: opts.cwd || tmpProjPath(),
      440 |         env: { ...(opts.env || process.env), NX_INVOKED_BY_RUNNER: undefined },
      441 |         encoding: 'utf-8',

      at runCLI (../utils/index.ts:438:15)
      at src/next.test.ts:613:29
      at ../../node_modules/tslib/tslib.js:117:75
      at __awaiter (../../node_modules/tslib/tslib.js:113:16)
      at checkApp (src/next.test.ts:416:34)
      at src/next.test.ts:299:11

Test Suites: 1 failed, 1 total
Tests:       2 failed, 14 passed, 16 total
Snapshots:   0 total
Time:        1005.679 s
Ran all test suites.
ERROR: Something went wrong in @nrwl/run-commands - Command failed: nx run-e2e-tests e2e-next

[puku0x]

Something wrong with withLess and withStylus

[puku0x]

withLess and withStylus should search the rule as following because Next.js uses Symbols for CSS rule.

• Before (v12.0.0)

const cssRule = config.module.rules.find((rule) =>
  rule.oneOf?.find((r) => r?.options?.__next_css_remove)
);

• After (v12.0.5)

const cssRule = config.module.rules.find((rule) =>
  rule.oneOf?.find((r) => r?.[Symbol.for('__next_css_remove')])
);

vercel/next.js#31078

[kirjai]

once again, thanks a lot for doing the work for this! really appreciated

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.