Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need all these dependencies to run it? #7

Open
OP-Klaus opened this issue Nov 30, 2017 · 1 comment
Open

Do we need all these dependencies to run it? #7

OP-Klaus opened this issue Nov 30, 2017 · 1 comment

Comments

@OP-Klaus
Copy link

OP-Klaus commented Nov 30, 2017 •
edited
Loading

When installed via npm this package is over 250mb, most of it is node_modules/babel*.
I don't see any reference to babel except in the npm scripts, so are they really necessary for the functioning of the package, or should some of them be in devDependencies?

Looking through the code, it seems that the only dependencies needed to run this are pluralize and superagent, with the others just being for building and testing, so I suggest moving the other modules to devDependencies
@snobb
Copy link

snobb commented Aug 18, 2021 •
edited
Loading

Exactly my observation as well. My project's node_modules is ~16Mb. Was that is.
Can you please move babel*, browserfy, etc to devDependencies?

snobb pushed a commit to snobb/ns1-js that referenced this issue Aug 18, 2021
Move dev dependencies to devDependencies.
6042668 
Also bump up the depenency versions.

Fixes ns1#7
snobb pushed a commit to snobb/ns1-js that referenced this issue Aug 18, 2021
Move dev dependencies to devDependencies. Fixes ns1#7
c8bbba0 
Also bump up the depenency versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snobb @OP-Klaus