Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tags respect base path #24

Merged
merged 2 commits into from
Mar 28, 2022
Merged

fix: tags respect base path #24

merged 2 commits into from
Mar 28, 2022

Conversation

loosheng
Copy link
Contributor

vite.config.ts

import { defineConfig } from 'vite';
import cesium from 'vite-plugin-cesium';
export default defineConfig({
  base:'./',
  plugins: [cesium()]
});

This pr previous build result , demo/dist/index.html.

<!DOCTYPE html>
<html lang="en">
  <head>
    <link rel="stylesheet" href="cesium/Widgets/widgets.css">
    <script src="cesium/Cesium.js"></script>

    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>cesium-vite</title>
    
    <script type="module" crossorigin src="./assets/index.1cfdf679.js"></script>
    <link rel="stylesheet" href="./assets/index.007faab3.css">
  </head>

  <body>
    <div id="cesiumContainer"></div>
  </body>
</html>

The build result after this pr , demo/dist/index.html.

<!DOCTYPE html>
<html lang="en">
  <head>
    <link rel="stylesheet" href="./cesium/Widgets/widgets.css">
    <script src="./cesium/Cesium.js"></script>

    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>cesium-vite</title>
    
    <script type="module" crossorigin src="./assets/index.1cfdf679.js"></script>
    <link rel="stylesheet" href="./assets/index.007faab3.css">
  </head>

  <body>
    <div id="cesiumContainer"></div>
  </body>
</html>

@nshen nshen merged commit ad3c4e2 into nshen:main Mar 28, 2022
@nshen
Copy link
Owner

nshen commented Mar 28, 2022

hi @loosheng is this PR fix the same program as 67542e0 ?

and sorry @lovefengruoqingI , I haven't check your PR yet, is this PR meets your needs?

@nshen nshen mentioned this pull request Mar 28, 2022
Closed
nshen added a commit that referenced this pull request Mar 28, 2022
@nshen
🚀 RELEASE: v1.2.14
786f86b 
- Fix: HTML tags should respect base path #22 #24

Thanks @loosheng and @lovefengruoqing
@subdavis subdavis mentioned this pull request Mar 30, 2022
Merged
@loosheng loosheng deleted the tags-src-path branch April 7, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loosheng @nshen