-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing user inputs from iceflow notebooks #50
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
👈 Launch a binder notebook on this branch for commit 74b76fc I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit 9f47d08 👈 Launch a binder notebook on this branch for commit 39d641d 👈 Launch a binder notebook on this branch for commit 7a3fb4a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Luis,
Apart from the issue with netrc authentication, I tested the notebooks using interactive authentication and they all worked. There was just one minor error in 3_dataviz.ipynb and I have added a comment with details.
notebooks/iceflow/3_dataviz.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cell:
my_df.widget.heatmap(my_df[df_key['longitude']],
my_df[df_key['latitude']],
what=vaex.stat.mean(my_df[df_key['elevation']]),
shape=512,
figsize=(10,6),
limits='minmax',
colormap='inferno')
This fails with the error: 'NameError: name 'observe' is not defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a bug with Vaex vaexio/vaex#2321 I'll try to debug it and see if there is a workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to use vaex 4.16.0 because it's the latest version on conda forge. I fixed 'NameError: name 'observe' is not defined
by adding from traitlets import Dict, observe
to packages/vaex-jupyter/vaex/jupyter/widgets.py
. I was going to make a PR for it however on master branch this fix is already in.
Co-authored-by: jroebuck932 <71841246+jroebuck932@users.noreply.github.com>
This PR will remove user input from Iceflow notebooks.