Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing user inputs from iceflow notebooks #50

Merged
merged 4 commits into from
Mar 21, 2023
Merged

removing user inputs from iceflow notebooks #50

merged 4 commits into from
Mar 21, 2023

Conversation

betolink
Copy link
Member

This PR will remove user input from Iceflow notebooks.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Binder 👈 Launch a binder notebook on this branch for commit 74b76fc

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 9f47d08

Binder 👈 Launch a binder notebook on this branch for commit 39d641d

Binder 👈 Launch a binder notebook on this branch for commit 7a3fb4a

@betolink betolink requested a review from jroebuck932 March 14, 2023 17:12
Copy link
Collaborator

@jroebuck932 jroebuck932 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Luis,
Apart from the issue with netrc authentication, I tested the notebooks using interactive authentication and they all worked. There was just one minor error in 3_dataviz.ipynb and I have added a comment with details.

notebooks/iceflow/0_introduction.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cell:

my_df.widget.heatmap(my_df[df_key['longitude']], 
               my_df[df_key['latitude']],
               what=vaex.stat.mean(my_df[df_key['elevation']]),
               shape=512, 
               figsize=(10,6),
               limits='minmax',
               colormap='inferno')

This fails with the error: 'NameError: name 'observe' is not defined

Copy link
Member Author

@betolink betolink Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bug with Vaex vaexio/vaex#2321 I'll try to debug it and see if there is a workaround.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to use vaex 4.16.0 because it's the latest version on conda forge. I fixed 'NameError: name 'observe' is not defined by adding from traitlets import Dict, observe to packages/vaex-jupyter/vaex/jupyter/widgets.py. I was going to make a PR for it however on master branch this fix is already in.

betolink and others added 2 commits March 15, 2023 13:18
Co-authored-by: jroebuck932 <71841246+jroebuck932@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants