Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nt tiepoints #58

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Fix nt tiepoints #58

merged 3 commits into from
Feb 17, 2024

Conversation

sc0tts
Copy link
Contributor

@sc0tts sc0tts commented Feb 15, 2024

This PR fixes some NT tie points for SMMR and F13. With these fixes, both are now consistent with the values used in CDRv4 via cdralgos.

Copy link
Contributor

@trey-stafford trey-stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I compared these updates to cdralgos' timeseries_constants.h and confirmed these changes reflect what I see there.

We should update the comments associated with the source for these tiepoints.

pm_icecon/nt/tiepoints.py Show resolved Hide resolved
pm_icecon/nt/tiepoints.py Outdated Show resolved Hide resolved
@trey-stafford
Copy link
Contributor

We should also bump the version and do a release! I can handle that.

@trey-stafford trey-stafford merged commit 37b317d into main Feb 17, 2024
1 check passed
@trey-stafford trey-stafford deleted the fix_NT_tiepoints branch February 17, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants