Trey updates #62
Merged
Trey updates #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 Is a legitimate concentration value (0%) representing open ocean. `np.nan` should be used to indicate missing areas.
This works for me, but we can revisit if needed.
|
All tests except one are passing. The failing test is a regression test that asserts our outputs match goddard's exactly for F17 NT. We may just want to update the regression data based on the changes made in #60 , but we should discuss. IIRC we did a fair bit of work to ensure that the values matched exactly with the outputs goddard gave us. The changes introduced here were in part to support how cdralgos implements the goddard algorithms, which is useful for our testing purposes but may not be an accurate reflection of goddard's original intent. Should we have a switch in the offending code that supports both methods, or is one way "right"? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves some issues with #60