Return FP strings for getunclaimedgas #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ type unclaimedGas struct { | |||
| func (g UnclaimedGas) MarshalJSON() ([]byte, error) { | |||
| gas := &unclaimedGas{ | |||
| Address: address.Uint160ToString(g.Address), | |||
| Unclaimed: g.Unclaimed.String(), | |||
| Unclaimed: util.DecimalToString(&g.Unclaimed, 8), | |||
There was a problem hiding this comment.
BTW, it's really a question if big.Int is suitable here. Technically, it'd be nice to have GAS values using the same type in every case.
|
cbececc has incorrect (after the move) commit message prefix. But this also allows us to fix neo-project/neo#2082 easily now, let's do that. |
roman-khimov
approved these changes
Dec 3, 2020
|
Just noticed that linter isn't happy. We can merge this and then fix neo-project/neo#2082 in a separate PR. |
Codecov Report
@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
+ Coverage 76.18% 81.34% +5.16%
==========================================
Files 238 239 +1
Lines 18758 18779 +21
==========================================
+ Hits 14291 15276 +985
+ Misses 3466 2513 -953
+ Partials 1001 990 -11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1570 .
We use
big.Intthere, so I've implemented functions inutil. They could be used in future in other places.