Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: signal JSON marshalling errors through exception #2461

Merged
merged 1 commit into from
May 4, 2022

Conversation

roman-khimov
Copy link
Member

See neo-project/neo-modules#696. Unmarshaller is left unchanged to be
compatible.

See neo-project/neo-modules#696. Unmarshaller is left unchanged to be
compatible.
@roman-khimov roman-khimov added this to the v0.99.0 milestone May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2461 (930c439) into master (3c0ee9c) will decrease coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
- Coverage   85.10%   85.03%   -0.08%     
==========================================
  Files         291      291              
  Lines       36732    36736       +4     
==========================================
- Hits        31262    31239      -23     
- Misses       4155     4185      +30     
+ Partials     1315     1312       -3     
Impacted Files Coverage Δ
pkg/services/oracle/network.go 75.86% <0.00%> (ø)
pkg/services/oracle/oracle.go 72.86% <ø> (-15.51%) ⬇️
pkg/rpc/response/result/invoke.go 81.74% <80.00%> (+0.59%) ⬆️
pkg/services/oracle/request.go 57.99% <0.00%> (-5.03%) ⬇️
pkg/network/server.go 74.11% <0.00%> (-0.10%) ⬇️
pkg/network/capability/capability.go 75.00% <0.00%> (+5.76%) ⬆️
pkg/network/message_string.go 77.41% <0.00%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8b259...930c439. Read the comment docs.

@roman-khimov roman-khimov merged commit 58bda8b into master May 4, 2022
@roman-khimov roman-khimov deleted the rpc-json-error-in-exception branch May 4, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants