Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: reduce maximum stckitem size #3185

Merged
merged 1 commit into from
Nov 13, 2023
Merged

vm: reduce maximum stckitem size #3185

merged 1 commit into from
Nov 13, 2023

Conversation

AnnaShaleva
Copy link
Member

To prevent possible DoS. Port the neo-project/neo-vm#514, close #3170.

Draft until some proximity to 0.104.0.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #3185 (b8a72c8) into master (dbd647e) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head b8a72c8 differs from pull request most recent head b0cdae4. Consider uploading reports for the commit b0cdae4 to get more accurate results

@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   85.38%   85.31%   -0.07%     
==========================================
  Files         326      326              
  Lines       43785    43775      -10     
==========================================
- Hits        37384    37345      -39     
- Misses       4927     4959      +32     
+ Partials     1474     1471       -3     
Files Coverage Δ
pkg/vm/stackitem/item.go 89.69% <ø> (ø)

... and 9 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

To prevent possible DoS. Port the neo-project/neo-vm#514,
close #3170.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva marked this pull request as ready for review November 13, 2023 17:40
@roman-khimov roman-khimov merged commit de2a445 into master Nov 13, 2023
11 of 16 checks passed
@roman-khimov roman-khimov deleted the fix-stackitem-limits branch November 13, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce stackitem limits
2 participants