Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.circleci: add go1.14 tests #775

Merged
merged 1 commit into from
Mar 25, 2020
Merged

.circleci: add go1.14 tests #775

merged 1 commit into from
Mar 25, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 17, 2020

Closes #771 .

@fyrchik
Copy link
Contributor Author

fyrchik commented Mar 17, 2020

Tests with '-race' flag fail because of etcd-io/bbolt#201 .

roman-khimov
roman-khimov requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait until Bolt issue is resolved, otherwise failing tests will create too much useless noise.

.circleci/config.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 18, 2020 •
edited
Loading

Codecov Report

Merging #775 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files         141      141           
  Lines       12963    12963           
=======================================
  Hits         8654     8654           
  Misses       3899     3899           
  Partials      410      410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396c78c...4fe8137. Read the comment docs.

@roman-khimov roman-khimov modified the milestone: v0.74.1 Mar 25, 2020
@roman-khimov roman-khimov merged commit 7f65e19 into master Mar 25, 2020
@roman-khimov roman-khimov deleted the feature/go1.14 branch March 25, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add go 1.14 support
2 participants
@fyrchik @roman-khimov