Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic precision convertations in inner ring #126

Merged
merged 4 commits into from
Oct 28, 2020

Conversation

alexvanin
Copy link
Contributor

@alexvanin alexvanin commented Oct 27, 2020

Related to #122

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #126 into master will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   44.11%   44.62%   +0.50%     
==========================================
  Files          52       53       +1     
  Lines        2525     2548      +23     
==========================================
+ Hits         1114     1137      +23     
  Misses       1291     1291              
  Partials      120      120              
Impacted Files Coverage Δ
pkg/util/precision/converter.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e9e25...a6243fe. Read the comment docs.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
@alexvanin
Copy link
Contributor Author

alexvanin commented Oct 27, 2020

Added precision.Convert() for in-place conversions. This could be useful in accounting.Balance when big.Int value from RPC node should be packed into Decimal with int64 value field.

@alexvanin alexvanin merged commit 330c4b4 into nspcc-dev:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neofs-ir Inner Ring node application issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants