Reduce returned balance precision in accounting.Balance #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 44.50% 44.64% +0.13%
==========================================
Files 53 53
Lines 2548 2549 +1
==========================================
+ Hits 1134 1138 +4
+ Misses 1293 1291 -2
+ Partials 121 120 -1
Continue to review full report at Codecov.
|
pkg/morph/client/util.go
Outdated
| func BigIntFromStackItem(param stackitem.Item) (*big.Int, error) { | ||
| switch param.Type() { | ||
| case stackitem.IntegerT, stackitem.ByteArrayT: | ||
| i, err := param.TryInteger() |
There was a problem hiding this comment.
Seems like we can do just
func BigIntFromStackItem(param stackitem.Item) (*big.Int, error) {
return param.TryInteger()
}
This is at odds with the approach used in other functions, so it can be done separately in a complex.
There was a problem hiding this comment.
Seems like a good option! Thank you, fixed.
cthulhu-rider
approved these changes
Oct 28, 2020
Neo-go can return big.Int values on stack after contract execution. Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Fixed8 won't overflow int64 for values less than 92 billion that is suitable for GAS. Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122
Before patch with
Fixed16precision in balance smart contract:neofs-cli -c config.yml accounting balance: -44.6744073709551586After patch:
neofs-cli -c config.yml accounting balance: 1800.00000000