Merge pull request #839 from ploxiln/no_lookupd_broadcast

nsqd: log errors if no nsqlookupd broadcast address
nsqio · Dec 29, 2016 · 02619e4 · 02619e4
2 parents c7623b5 + 28dbeaf
commit 02619e4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/nsqd/lookup.go b/nsqd/lookup.go
@@ -37,6 +37,9 @@ func connectCallback(n *NSQD, hostname string, syncTopicChan chan *lookupPeer) f
 				n.logf("LOOKUPD(%s): ERROR parsing response - %s", lp, resp)
 			} else {
 				n.logf("LOOKUPD(%s): peer info %+v", lp, lp.Info)
+				if lp.Info.BroadcastAddress == "" {
+					n.logf("LOOKUPD(%s): ERROR - no broadcast address", lp)
+				}
 			}
 		}
 

diff --git a/nsqd/nsqd.go b/nsqd/nsqd.go
@@ -456,6 +456,8 @@ func (n *NSQD) GetTopic(topicName string) *Topic {
 			}
 			t.getOrCreateChannel(channelName)
 		}
+	} else if len(n.getOpts().NSQLookupdTCPAddresses) > 0 {
+		n.logf("ERROR: no available nsqlookupd to query for channels to pre-create for topic %s", t.name)
 	}
 
 	t.Unlock()