Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqd: /info api should return more configuration metadata #1401

Closed
ctlove0523 opened this issue Apr 24, 2022 · 2 comments
Closed

nsqd: /info api should return more configuration metadata #1401

ctlove0523 opened this issue Apr 24, 2022 · 2 comments
Labels

Comments

@ctlove0523
Copy link

ctlove0523 commented Apr 24, 2022

run one nsqd instance on the localhost with default config,current /info api returns looks like below:

{
    "version": "1.2.1",
    "broadcast_address": "DESKTOP-TJTHRU9",
    "hostname": "DESKTOP-TJTHRU9",
    "http_port": 4151,
    "tcp_port": 4150,
    "start_time": 1650760244
}

but this information not enough for client to connect to nsqd instance,for example when client use tcp protocol connect nsqd and then send IDENTIFY command,client may want to configure heartbeat_intervaloutput_buffer_sizeoutput_buffer_timeout and deflate_level,the maximum value of these four configurations controlled by nsqd config:

1、heartbeat_interval value range [1000,configured_max] --max-heartbeat-interval flag controls the configured_max value
2、output_buffer_size value range [64,configured_max] --max-output-buffer-size flag controls the configured_max value
3、output_buffer_timeout  value range [1ms,configured_max] --max-output-buffer-timeout flag controls the configured_max value and default is 250ms
4、deflate_level  value range [1,configured_max] --max-deflate-level flag controls the configured_max value

so if /info api can return these four configurations value is helpful,api returns may looks like below:

{
    "version":"1.2.1",
    "broadcast_address":"DESKTOP-TJTHRU9",
    "hostname":"DESKTOP-TJTHRU9",
    "http_port":4151,
    "tcp_port":4150,
    "start_time":1650760244,
    "max_heartbeat_interval":80000,
    "max_output_buffer_size":128,
    "max_output_buffer_timeout":500,
    "max_deflate_level":100
}
@mreiferson
Copy link
Member

This seems like a reasonable idea.

@mreiferson mreiferson changed the title nsqd /info api returns more information about nsqd instance. nsqd: /info api should return more configuration metadata May 1, 2022
@ploxiln
Copy link
Member

ploxiln commented Jun 5, 2022

looks like this was done in #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants