Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: won't compile on illumos #765

Closed
Licenser opened this issue May 27, 2016 · 1 comment · Fixed by #1195
Closed

nsqd: won't compile on illumos #765

Licenser opened this issue May 27, 2016 · 1 comment · Fixed by #1195
Labels
bug help wanted

Comments

@Licenser
Copy link

It seems that dirlock depends on some Linux specific syscalls, compilation of NSQd fails with the following output

# github.com/nsqio/nsq/internal/dirlock
../.go/src/github.com/nsqio/nsq/internal/dirlock/dirlock.go:28: undefined: syscall.Flock
../.go/src/github.com/nsqio/nsq/internal/dirlock/dirlock.go:28: undefined: syscall.LOCK_EX
../.go/src/github.com/nsqio/nsq/internal/dirlock/dirlock.go:28: undefined: syscall.LOCK_NB
../.go/src/github.com/nsqio/nsq/internal/dirlock/dirlock.go:37: undefined: syscall.Flock
../.go/src/github.com/nsqio/nsq/internal/dirlock/dirlock.go:37: undefined: syscall.LOCK_UN
@mreiferson mreiferson added the bug label May 29, 2016
@mreiferson
Copy link
Member

just need to add a compiler flag to noop the implementation on illumos

i-sevostyanov added a commit to i-sevostyanov/nsq that referenced this issue Oct 1, 2019
@i-sevostyanov
Fix compilation on illumos.
72cbb40 
Fixes nsqio#765
@i-sevostyanov i-sevostyanov mentioned this issue Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dirlock: fix compilation on illumos. i-sevostyanov/nsq
2 participants
@Licenser @mreiferson