Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqlookupd: better API when used as a library #1004

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

stephens2424
Copy link

for package importers to get error info, and to allow importers avoid a call to os.Exit.

fixes #1003

@mreiferson
Copy link
Member

I'm fine with cleaning this up, and I don't particularly care about backwards compatibility (which we haven't traditionally guaranteed when using NSQ as a library).

Instead I would suggest making Main() actually behave appropriately by returning an error and promote the logging and exiting to the package main code paths.

@mreiferson mreiferson changed the title adding a MainErr function to nsqlookupd nsqlookupd: better API when used as a library Mar 3, 2018
@stephens2424 stephens2424 force-pushed the 1003 branch 2 times, most recently from 7cc329f to fa17bfb Compare March 6, 2018 14:20
@ploxiln
Copy link
Member

ploxiln commented Jun 2, 2018

looks like this was updated (it helps to comment after updating the PR branch, because sometimes github doesn't notify for that)

@mreiferson
Copy link
Member

yea, this LGTM

@mreiferson
Copy link
Member

ok, fixed up this commit msg

@mreiferson mreiferson merged commit 6e91892 into nsqio:master Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nsqlookupd: Main() has no way to expose its errors and calls os.Exit
3 participants