delete channel ordering issues #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some |
arussellsaw
pushed a commit
to arussellsaw/nsq
that referenced
this pull request
Mar 5, 2018
…qio#101) - Matches nsqd's -tls-min-version flag format, which was changed in bitly/nsqd#518 - Defaults tls min version to TLS1.0 - Sets tls max version to enable TLS_FALLBACK_SCSV prior to Go 1.5 - see https://go-review.googlesource.com/#/c/1776/ (thanks @jehiah)
arussellsaw
pushed a commit
to arussellsaw/nsq
that referenced
this pull request
Mar 5, 2018
tls updates: match nsqd min version flag, set default max/min (per nsqio#101)
absolute8511
added a commit
to absolute8511/nsq
that referenced
this pull request
Jan 12, 2023
adjust balance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we dont do any locking or checks around channel deletion to ensure that the diskqueue is properly disposed of.
there are edge cases where messages in a channel diskqueue are in-flight, the channel is deleted, and those messages end up getting written to a file that should be deleted.
cc @bitly/nsq