nsqadmin: html-escaping large_graph url breaks inside javascript #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehiah
approved these changes
Aug 3, 2018
|
alrighty, it works now. I'll squash down (all but the |
|
side note, I currently have this mini script I run as #!/bin/sh
set -eu
go-bindata --modtime=1533016989 --pkg=nsqadmin "$@" --prefix=static/build static/build/...
gofmt -w bindata.go |
|
cool |
ends up like /render?colorList=green&height=450&... '=' was not escaped to "=" before recent js lib updates this starts the url "hash" part which is not sent to the server so put html-escaped url in plainer html part of page (src attribute)
ploxiln
force-pushed
the
admin_counter_graph
branch
from
701eb95 to
d246d15
Compare
|
squashed a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ends up like
/render?colorList=green&height=450&...=was not escaped to=beforethis starts the url hash which is not sent to the server
I'm still validating that this change actually fixes it
cc @jehiah